-
Notifications
You must be signed in to change notification settings - Fork 586
Partition-to-segment rename (wave 3): Python SDK #12059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/19887092630 |
60eb3e6 to
e88745d
Compare
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/19887747649 |
ntjohnson1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the deprecation warnings just to ease the transition a little bit. The only downside I see if needing to remember to remove them in 0.29. Globally across the rename I'd consider the deprecation stuff a nice to have not need to have.
| return self._internal.set_default_blueprint_segment_id(segment_id) | ||
|
|
||
| @deprecated("Use default_blueprint_segment_id() instead") | ||
| def default_blueprint_partition_id(self) -> str | None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is another nice feature of the pure python wrappers!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes!
e88745d to
e78ccdf
Compare
e78ccdf to
4944365
Compare
Related
What
Rename all instances of "partition" to "segment" in the Python SDK. Keep the old function around with a deprecation warning.
DNM: