Skip to content

Conversation

@abey79
Copy link
Member

@abey79 abey79 commented Dec 2, 2025

Related

What

Rename all instances of "partition" to "segment" in the Python SDK. Keep the old function around with a deprecation warning.

DNM:

  • chained
  • needs a dpf sibling

@abey79 abey79 added sdk-python Python logging API do-not-merge Do not merge this PR 🚜 refactor Change the code, not the functionality include in changelog labels Dec 2, 2025
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Web viewer built successfully.

Result Commit Link Manifest
4944365 https://rerun.io/viewer/pr/12059 +nightly +main

View image diff on kitdiff.

Note: This comment is updated whenever you push a commit.

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Latest documentation preview deployed successfully.

Result Commit Link
4944365 https://landing-qcpo1r8bn-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@abey79 abey79 changed the title Rename all apis Partition-to-segment rename (wave 3): Python SDK Dec 2, 2025
@abey79 abey79 marked this pull request as ready for review December 2, 2025 17:33
@abey79
Copy link
Member Author

abey79 commented Dec 3, 2025

@rerun-bot full-check

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Base automatically changed from antoine/partition-to-segment-2-re-uri to main December 3, 2025 08:42
@abey79 abey79 force-pushed the antoine/partition-to-segment-3-sdk branch from 60eb3e6 to e88745d Compare December 3, 2025 08:44
@abey79 abey79 removed the do-not-merge Do not merge this PR label Dec 3, 2025
@abey79
Copy link
Member Author

abey79 commented Dec 3, 2025

@rerun-bot full-check

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Copy link
Member

@ntjohnson1 ntjohnson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the deprecation warnings just to ease the transition a little bit. The only downside I see if needing to remember to remove them in 0.29. Globally across the rename I'd consider the deprecation stuff a nice to have not need to have.

return self._internal.set_default_blueprint_segment_id(segment_id)

@deprecated("Use default_blueprint_segment_id() instead")
def default_blueprint_partition_id(self) -> str | None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another nice feature of the pure python wrappers!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

@abey79 abey79 force-pushed the antoine/partition-to-segment-3-sdk branch from e88745d to e78ccdf Compare December 3, 2025 12:39
@abey79 abey79 force-pushed the antoine/partition-to-segment-3-sdk branch from e78ccdf to 4944365 Compare December 3, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

include in changelog 🚜 refactor Change the code, not the functionality sdk-python Python logging API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants